----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4485/#review6360 -----------------------------------------------------------
I think 'make hadoop' will fail. Please update the Hadoop patch too. include/mesos/mesos.proto <https://reviews.apache.org/r/4485/#comment13788> You shouldn't link this protobuf explicitly to the downloading of files before running the executor command. Otherwise if you prefer to do it that way, embed the message in CommandInfo please. src/common/type_utils.hpp <https://reviews.apache.org/r/4485/#comment13789> Factor out into operator == for URI please. src/launcher/launcher.cpp <https://reviews.apache.org/r/4485/#comment13790> Indent. src/launcher/launcher.cpp <https://reviews.apache.org/r/4485/#comment13791> Space after foreach. src/launcher/launcher.cpp <https://reviews.apache.org/r/4485/#comment13792> s/r/R src/launcher/launcher.cpp <https://reviews.apache.org/r/4485/#comment13793> strings::trim? src/launcher/main.cpp <https://reviews.apache.org/r/4485/#comment13794> Space after foreach. src/launcher/main.cpp <https://reviews.apache.org/r/4485/#comment13795> Factor getenv("MESOS_EXECUTOR_URIS") into a local string uris, then you won't have to wrap this line. src/launcher/main.cpp <https://reviews.apache.org/r/4485/#comment13797> s/d/D src/launcher/main.cpp <https://reviews.apache.org/r/4485/#comment13796> Space around '+'. - Benjamin On 2012-03-26 18:39:25, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4485/ > ----------------------------------------------------------- > > (Updated 2012-03-26 18:39:25) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > CommandInfo now accepts a list of URIs. > > Also added the ability to selectively set the executable > bit on the downloaded files. > > > This addresses bug mesos-171. > https://issues.apache.org/jira/browse/mesos-171 > > > Diffs > ----- > > include/mesos/mesos.proto 23aad17 > src/common/type_utils.hpp 557abd7 > src/examples/java/TestFramework.java f86646b > src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 > src/examples/long_lived_framework.cpp 2775f5a > src/examples/test_framework.cpp 622f6ac > src/launcher/launcher.hpp b48d97c > src/launcher/launcher.cpp 8545193 > src/launcher/main.cpp 80567e9 > src/slave/http.cpp b9f3232 > src/slave/lxc_isolation_module.cpp aff6da6 > src/slave/process_based_isolation_module.cpp 4280410 > > Diff: https://reviews.apache.org/r/4485/diff > > > Testing > ------- > > make check. > > Yet to test it on a linux machine, as some of the changes affect the lxc code. > > > Thanks, > > Vinod > >
