----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4491/#review6383 -----------------------------------------------------------
README <https://reviews.apache.org/r/4491/#comment13883> You might want to provide an example of installing to a non-local prefix, because some users will probably not be familiar with the concept. Then refer back to this at the start of the next section. README <https://reviews.apache.org/r/4491/#comment13884> Put prefix in [brackets] README <https://reviews.apache.org/r/4491/#comment13894> Mention that the scripts also need Mesos to be installed to the same prefix on all machines. README <https://reviews.apache.org/r/4491/#comment13880> But the slaves-env.sh file needs to be on all the nodes, right? If the intent is to ship the options automatically, that would make it hard for the user to configure, say, different numbers of CPUs and memory per host, or a different LIBPROCESS_IP, or stuff like that. README <https://reviews.apache.org/r/4491/#comment13886> Why is this not called start-mesos anymore? If it's to keep it in line with the rest of the binaries we put on the PATH, I would go for something like mesos-start-cluster.sh, which seems more grammatically correct than just "start". src/Makefile.am <https://reviews.apache.org/r/4491/#comment13887> Just to double-check, if someone does a make install, then modifies some config files, and then downloads a new version of Mesos and does make install again, will their directories be overwritten? Or does install protect the existing files? src/deploy/mesos-deploy-env.sh.in <https://reviews.apache.org/r/4491/#comment13888> Would be nice to have a list of the variables that can be set here. src/deploy/mesos-masters-env.sh.in <https://reviews.apache.org/r/4491/#comment13889> Say that you can run mesos-master --help for a list of parameters. src/deploy/mesos-start-masters.sh.in <https://reviews.apache.org/r/4491/#comment13892> What does this do? If you're trying to ship the env variables from the local config files to the machine, shouldn't you do export ${var} = value? Also, gotta be careful with quoting here. src/deploy/mesos-start-slaves.sh.in <https://reviews.apache.org/r/4491/#comment13891> Ditto to the similar thing in masters script. src/tests/master_detector_tests.cpp <https://reviews.apache.org/r/4491/#comment13895> Was this included in the patch by mistake? - Matei On 2012-03-26 21:38:18, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4491/ > ----------------------------------------------------------- > > (Updated 2012-03-26 21:38:18) > > > Review request for mesos, Andy Konwinski and Matei Zaharia. > > > Summary > ------- > > Updated deploy scripts to work with latest version of Mesos. Eliminated > 'deploy-to-slaves' functionality, instead we assume the binaries and > libraries will get installed via other means. Updated the semantics of where > configuration options are gathered from since a single configuration file was > insufficient given conflicting configuration options between binaries (e.g., > mesos-master and mesos-slave). Added a section to the README describing these > scripts. > > > Diffs > ----- > > README 8166b04 > configure.ac 7a0d89f > src/Makefile.am 090c07a > src/conf/deploy-env.sh.template a4565e2 > src/configurator/configurator.hpp ecd1365 > src/deploy/deploy-to-slaves 0e10486 > src/deploy/mesos-common-env.sh.in PRE-CREATION > src/deploy/mesos-daemon b3144c0 > src/deploy/mesos-daemon.sh.in PRE-CREATION > src/deploy/mesos-deploy-env.sh.in PRE-CREATION > src/deploy/mesos-env.sh c3dfda2 > src/deploy/mesos-masters-env.sh.in PRE-CREATION > src/deploy/mesos-slaves-env.sh.in PRE-CREATION > src/deploy/mesos-start-masters.sh.in PRE-CREATION > src/deploy/mesos-start-slaves.sh.in PRE-CREATION > src/deploy/mesos-start.sh.in PRE-CREATION > src/deploy/mesos-stop-masters.sh.in PRE-CREATION > src/deploy/mesos-stop-slaves.sh.in PRE-CREATION > src/deploy/mesos-stop.sh.in PRE-CREATION > src/deploy/start-masters a450ee0 > src/deploy/start-mesos 9e5b922 > src/deploy/start-slaves b3b931f > src/deploy/stop-masters f2aa9e2 > src/deploy/stop-mesos 679a09e > src/deploy/stop-slaves 141acd4 > src/master/main.cpp f31212b > src/tests/master_detector_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/4491/diff > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin > >
