----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4299/#review6408 -----------------------------------------------------------
Ship it! LGTM. hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch <https://reviews.apache.org/r/4299/#comment14010> Okay, but I'd prefer multiple lines for this. - Charles On 2012-03-27 05:17:53, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4299/ > ----------------------------------------------------------- > > (Updated 2012-03-27 05:17:53) > > > Review request for mesos, Charles Reiss and Jessica. > > > Summary > ------- > > See summary. > > Note to Jessica: I made JAVA_HOME be optional, but it doesn't sound like this > would be sufficient in your environment. Do you think adding a check for > 'javac' under JAVA_HOME would help? Any other suggestions? > > > This addresses bug MESOS-148. > https://issues.apache.org/jira/browse/MESOS-148 > > > Diffs > ----- > > hadoop/TUTORIAL 38d2c17 > hadoop/TUTORIAL.sh 16d87f0 > hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 35c16a6 > > Diff: https://reviews.apache.org/r/4299/diff > > > Testing > ------- > > make && make hadoop > > > Thanks, > > Benjamin > >
