----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4491/#review6455 -----------------------------------------------------------
This looks good, except for a few minor things: 1) If you just run these out of the box, the slave will silently fail to start because its "--master" command line flag is not passed. We should tell the user to configure this in mesos.conf, or try to set it automatically if there is only one slave. 2) The previous scripts attempted to automatically find the amount of cores and memory available. Should we add that back? 3) It's not clear that the master and slaves are logging to anywhere (if you just run /sbin/mesos-master for example, it says "Logging to" and does not give a path). If they aren't, we should update the docs to say that you can turn on logging by setting log_dir. Ditto for the work directory (where will that be after a make install? It seems like the default is ./work). - Matei On 2012-03-27 21:15:39, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4491/ > ----------------------------------------------------------- > > (Updated 2012-03-27 21:15:39) > > > Review request for mesos, Andy Konwinski and Matei Zaharia. > > > Summary > ------- > > Updated deploy scripts to work with latest version of Mesos. Eliminated > 'deploy-to-slaves' functionality, instead we assume the binaries and > libraries will get installed via other means. Updated the semantics of where > configuration options are gathered from since a single configuration file was > insufficient given conflicting configuration options between binaries (e.g., > mesos-master and mesos-slave). Added a section to the README describing these > scripts. > > > Diffs > ----- > > README 8166b04 > configure.ac 7a0d89f > src/Makefile.am 448410e > src/conf/deploy-env.sh.template a4565e2 > src/configurator/configurator.hpp ecd1365 > src/configurator/configurator.cpp 1f8134c > src/deploy/deploy-to-slaves 0e10486 > src/deploy/mesos-daemon b3144c0 > src/deploy/mesos-daemon.sh.in PRE-CREATION > src/deploy/mesos-deploy-env.sh.template PRE-CREATION > src/deploy/mesos-env.sh 14ad67a > src/deploy/mesos-start-cluster.sh.in PRE-CREATION > src/deploy/mesos-start-masters.sh.in PRE-CREATION > src/deploy/mesos-start-slaves.sh.in PRE-CREATION > src/deploy/mesos-stop-cluster.sh.in PRE-CREATION > src/deploy/mesos-stop-masters.sh.in PRE-CREATION > src/deploy/mesos-stop-slaves.sh.in PRE-CREATION > src/deploy/start-masters a450ee0 > src/deploy/start-mesos 9e5b922 > src/deploy/start-slaves b3b931f > src/deploy/stop-masters f2aa9e2 > src/deploy/stop-mesos 679a09e > src/deploy/stop-slaves 141acd4 > src/master/main.cpp e88315f > > Diff: https://reviews.apache.org/r/4491/diff > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin > >
