> On 2012-03-28 05:15:19, Vinod Kone wrote: > > src/common/utils.hpp, line 499 > > <https://reviews.apache.org/r/4532/diff/1/?file=97179#file97179line499> > > > > is this supported on all platforms?
This is from unistd.h ... do a 'man sysconf'. Doesn't mean all platforms support it, but the ones I care about do (Linux and Mac OS X). > On 2012-03-28 05:15:19, Vinod Kone wrote: > > src/slave/slave.cpp, line 99 > > <https://reviews.apache.org/r/4532/diff/1/?file=97180#file97180line99> > > > > what is this memory calculation? Ah, it's supposed to leave 1 GB of available memory on the machine. But it look's horribly broken. :/ Fixed. > On 2012-03-28 05:15:19, Vinod Kone wrote: > > src/slave/slave.cpp, line 104 > > <https://reviews.apache.org/r/4532/diff/1/?file=97180#file97180line104> > > > > sweet > > Sweeeeeeeeet. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4532/#review6470 ----------------------------------------------------------- On 2012-03-28 04:56:13, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4532/ > ----------------------------------------------------------- > > (Updated 2012-03-28 04:56:13) > > > Review request for mesos, Andy Konwinski, Matei Zaharia, and Vinod Kone. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > src/common/utils.hpp 8a7b2d1 > src/slave/slave.cpp c592229 > third_party/libprocess/src/process.cpp b07c52a > > Diff: https://reviews.apache.org/r/4532/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
