----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4563/#review6550 -----------------------------------------------------------
src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14212> Why not just use DebugString from protobuf and wrap it in an operator << in type_utils.hpp? src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14211> Spaces between '='. src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14210> Previous line. src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14213> s/temp/range src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14214> This needs to be temp.begin() and temp.end(), since it might be changing. Please just kill add_begin, add_end. src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14215> Might as well just use range.begin/end below since you're doing that above. src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14219> Consider: const Value::Range& current = ranges->range(i); if (range.begin() <= current.begin() && ...) src/common/values.cpp <https://reviews.apache.org/r/4563/#comment14217> None of the continue statements are necessary. src/tests/resources_tests.cpp <https://reviews.apache.org/r/4563/#comment14220> Kind of redundant! src/tests/resources_tests.cpp <https://reviews.apache.org/r/4563/#comment14221> Newline. src/tests/resources_tests.cpp <https://reviews.apache.org/r/4563/#comment14224> Please use comparisons which do "set" equality. src/tests/resources_tests.cpp <https://reviews.apache.org/r/4563/#comment14228> Please use comparisons which do "set" equality. - Benjamin On 2012-03-29 23:15:54, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4563/ > ----------------------------------------------------------- > > (Updated 2012-03-29 23:15:54) > > > Review request for mesos and Bill Farner. > > > Summary > ------- > > Fixed both coalesce() and remove() > > > Diffs > ----- > > src/common/resources.hpp f367896 > src/common/values.cpp e6f1a85 > src/tests/resources_tests.cpp 7a68ed9 > > Diff: https://reviews.apache.org/r/4563/diff > > > Testing > ------- > > GLOG_v=1 bin/mesos-tests.sh -v --gtest_filter="*Ranges*" > > > Thanks, > > Vinod > >
