-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4768/
-----------------------------------------------------------

(Updated 2012-04-20 08:17:57.362659)


Review request for mesos, Benjamin Hindman and Charles Reiss.


Changes
-------

Added optional --name, --path for directory of mpich2 binaries, and --ifhn 
tags. 


Summary
-------

Some updates to point out:

-nmpiexec.py
  -> 'mpdallexit' should terminate all slaves' mpds in the ring. I moved 
'driver.stop()' to statusUpdate() so that it stops when all tasks have been 
finished, which occurs when the executor's launched mpd processes have all 
exited. 
-startmpd.py
  -> Didn't remove cleanup(), and added code in shutdown() that manually kills 
mpd processes. They might be useful during abnormal (cleanup) and normal 
(shutdown) framework/executor termination...I think. cleanup() still terminates 
all mpd's in the slave, but shutdown doesn't. 
  -> killtask() stops the mpd associated with the given tid. 
  -> Task states update nicely now. They correspond to the state of a task's 
associated mpd process.
-Readme
  -> Included additional info on how to setup and run MPICH2 1.2 and nmpiexec 
on OS X and Ubuntu/Linux


This addresses bug MESOS-183.
    https://issues.apache.org/jira/browse/MESOS-183


Diffs (updated)
-----

  frameworks/mpi/README.txt cdb4553 
  frameworks/mpi/nmpiexec.py a5db9c0 
  frameworks/mpi/startmpd.py 8eeba5e 

Diff: https://reviews.apache.org/r/4768/diff


Testing
-------


Thanks,

Harvey

Reply via email to