----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4848/#review7183 -----------------------------------------------------------
Ship it! src/zookeeper/detector.hpp <https://reviews.apache.org/r/4848/#comment15848> Does difference mean memeber id set diff or id + data diff -> document it. src/zookeeper/detector.cpp <https://reviews.apache.org/r/4848/#comment15849> I think you can eliminate the Option midlleman here. Can you also factor out a helper? - this same code is in the destructor above. - John On 2012-04-23 20:57:10, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4848/ > ----------------------------------------------------------- > > (Updated 2012-04-23 20:57:10) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 5b5f4a6 > src/tests/zookeeper_tests.cpp a852103 > src/zookeeper/detector.hpp PRE-CREATION > src/zookeeper/detector.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/4848/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
