Re: Review Request: Fixes a bug when a coordinator tried to fill positions that other replicas had already learned were truncated (note that the test added failed before the rest of the patch got applied).

[John Sirois]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4867/#review7207
-----------------------------------------------------------

Ship it!


The 2 key comments are very clear here.  Thanks.

- John


On 2012-04-25 01:09:19, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4867/
> -----------------------------------------------------------
> 
> (Updated 2012-04-25 01:09:19)
> 
> 
> Review request for mesos and John Sirois.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/coordinator.hpp 16b15f0 
>   src/log/coordinator.cpp 25127ee 
>   src/log/log.hpp ebdb0b8 
>   src/log/replica.cpp 8d03304 
>   src/tests/log_tests.cpp 97712dd 
> 
> Diff: https://reviews.apache.org/r/4867/diff
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin
> 
>