> On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 138 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line138> > > > > s/slave "/slave on "
done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 176 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line176> > > > > Ditto above. done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 667 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line667> > > > > I suggest just killing this LOG line and keeping the new one you added > > below. done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 756 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line756> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 801 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line801> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 848 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line848> > > > > s/slave "/slave on " > > > > Note also that anytime we are printing out the PID, we're getting the > > IP, so the hostname is not strictly necessary (there a bunch of these > > below). fixed. reg: hostname, i think having it makes debugging less painful. > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 894 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line894> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 905 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line905> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 947 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line947> > > > > ? reverted > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 978 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line978> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 984 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line984> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 1007 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1007> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 1020 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1020> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 1446 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1446> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 1504 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1504> > > > > s/"("/" (" done > On 2012-04-25 22:11:01, Benjamin Hindman wrote: > > src/master/master.cpp, line 1731 > > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1731> > > > > s/"("/" (" done - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4462/#review7232 ----------------------------------------------------------- On 2012-04-19 16:53:07, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4462/ > ----------------------------------------------------------- > > (Updated 2012-04-19 16:53:07) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > Sorry for the huge CL! > > Slave restarts now supports recovery! > --> Non-disruptive restart means running tasks are not lost > --> Re-connects with live executors > --> Checkpoints and reliably sends status updates > --> Ability to kill executors if the slave upgrade is incompatible with > running executors > > > This addresses bug mesos-110. > https://issues.apache.org/jira/browse/mesos-110 > > > Diffs > ----- > > src/Makefile.am d5edaa2 > src/common/hashset.hpp 1feb610 > src/common/utils.hpp 1d81e21 > src/exec/exec.cpp e8db407 > src/launcher/launcher.cpp a141b9a > src/local/local.hpp 55f9eaf > src/local/local.cpp affe432 > src/master/master.cpp 4dc9ee0 > src/messages/messages.proto 87e1548 > src/sched/sched.cpp dcadb10 > src/scripts/killtree.sh bceae9d > src/slave/constants.hpp f0c8679 > src/slave/http.cpp 19c48a0 > src/slave/isolation_module.hpp c896908 > src/slave/lxc_isolation_module.hpp b7beefe > src/slave/lxc_isolation_module.cpp 66a2a89 > src/slave/main.cpp 85cba25 > src/slave/process_based_isolation_module.hpp f6f9554 > src/slave/process_based_isolation_module.cpp 2b37d42 > src/slave/slave.hpp 279bc7b > src/slave/slave.cpp 3358ec4 > src/slave/statusupdates_manager.hpp PRE-CREATION > src/slave/statusupdates_manager.cpp PRE-CREATION > src/tests/external_tests.cpp d1b20e4 > src/tests/fault_tolerance_tests.cpp 6772daf > src/tests/slave_restart_tests.cpp PRE-CREATION > src/tests/utils.hpp e81ec82 > > Diff: https://reviews.apache.org/r/4462/diff > > > Testing > ------- > > make check. > > Note that only the new test in tests/slave_restart_tests.cpp engages in > recovery! > > Recovery is disabled for old tests (though they still checkpoint relevant > info!) > > > Thanks, > > Vinod > >
