[
https://issues.apache.org/jira/browse/MESOS-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263376#comment-13263376
]
[email protected] commented on MESOS-110:
-----------------------------------------------------
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 138
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line138>
bq. >
bq. > s/slave "/slave on "
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 176
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line176>
bq. >
bq. > Ditto above.
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 667
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line667>
bq. >
bq. > I suggest just killing this LOG line and keeping the new one you
added below.
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 756
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line756>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 801
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line801>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 848
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line848>
bq. >
bq. > s/slave "/slave on "
bq. >
bq. > Note also that anytime we are printing out the PID, we're getting
the IP, so the hostname is not strictly necessary (there a bunch of these
below).
fixed.
reg: hostname, i think having it makes debugging less painful.
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 894
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line894>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 905
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line905>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 947
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line947>
bq. >
bq. > ?
reverted
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 978
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line978>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 984
bq. > <https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line984>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 1007
bq. >
<https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1007>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 1020
bq. >
<https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1020>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 1446
bq. >
<https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1446>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 1504
bq. >
<https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1504>
bq. >
bq. > s/"("/" ("
done
bq. On 2012-04-25 22:11:01, Benjamin Hindman wrote:
bq. > src/master/master.cpp, line 1731
bq. >
<https://reviews.apache.org/r/4462/diff/3/?file=103029#file103029line1731>
bq. >
bq. > s/"("/" ("
done
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4462/#review7232
-----------------------------------------------------------
On 2012-04-19 16:53:07, Vinod Kone wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4462/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 16:53:07)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and John Sirois.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Sorry for the huge CL!
bq.
bq. Slave restarts now supports recovery!
bq. --> Non-disruptive restart means running tasks are not lost
bq. --> Re-connects with live executors
bq. --> Checkpoints and reliably sends status updates
bq. --> Ability to kill executors if the slave upgrade is incompatible with
running executors
bq.
bq.
bq. This addresses bug mesos-110.
bq. https://issues.apache.org/jira/browse/mesos-110
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/Makefile.am d5edaa2
bq. src/common/hashset.hpp 1feb610
bq. src/common/utils.hpp 1d81e21
bq. src/exec/exec.cpp e8db407
bq. src/launcher/launcher.cpp a141b9a
bq. src/local/local.hpp 55f9eaf
bq. src/local/local.cpp affe432
bq. src/master/master.cpp 4dc9ee0
bq. src/messages/messages.proto 87e1548
bq. src/sched/sched.cpp dcadb10
bq. src/scripts/killtree.sh bceae9d
bq. src/slave/constants.hpp f0c8679
bq. src/slave/http.cpp 19c48a0
bq. src/slave/isolation_module.hpp c896908
bq. src/slave/lxc_isolation_module.hpp b7beefe
bq. src/slave/lxc_isolation_module.cpp 66a2a89
bq. src/slave/main.cpp 85cba25
bq. src/slave/process_based_isolation_module.hpp f6f9554
bq. src/slave/process_based_isolation_module.cpp 2b37d42
bq. src/slave/slave.hpp 279bc7b
bq. src/slave/slave.cpp 3358ec4
bq. src/slave/statusupdates_manager.hpp PRE-CREATION
bq. src/slave/statusupdates_manager.cpp PRE-CREATION
bq. src/tests/external_tests.cpp d1b20e4
bq. src/tests/fault_tolerance_tests.cpp 6772daf
bq. src/tests/slave_restart_tests.cpp PRE-CREATION
bq. src/tests/utils.hpp e81ec82
bq.
bq. Diff: https://reviews.apache.org/r/4462/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check.
bq.
bq. Note that only the new test in tests/slave_restart_tests.cpp engages in
recovery!
bq.
bq. Recovery is disabled for old tests (though they still checkpoint relevant
info!)
bq.
bq.
bq. Thanks,
bq.
bq. Vinod
bq.
bq.
> Mesos deploys should not restart tasks
> --------------------------------------
>
> Key: MESOS-110
> URL: https://issues.apache.org/jira/browse/MESOS-110
> Project: Mesos
> Issue Type: Improvement
> Components: framework
> Reporter: Rob Benson
> Assignee: Vinod Kone
>
> Running a long-lived service on Mesos has a significant drawback right now in
> that Mesos build deploys restart your tasks. This could lead to nontrivial
> outages for services that have a high warm-up time. Basically everything
> would need a graceful restart mechanism that basically allows a
> shutdown/restart with a new version of the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
