-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4922/#review7341
-----------------------------------------------------------
Ship it!
Looks okay to me. If you want to avoid the library finding, you should be able
to do ${MESOS_BUILD_DIR}/libtool --mode=install cp
${MESOS_BUILD_DIR}/src/libmesos.la lib/native/${PLATFORM}, but I'm not
convinced this is better.
hadoop/Makefile.am
<https://reviews.apache.org/r/4922/#comment16220>
Why the dependency on 'all'? (and elsewhere)
- Charles
On 2012-04-28 01:28:09, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4922/
> -----------------------------------------------------------
>
> (Updated 2012-04-28 01:28:09)
>
>
> Review request for mesos, Charles Reiss and Matei Zaharia.
>
>
> Summary
> -------
>
> I wanted to break down the changes to Hadoop so that someone could see
> exactly how minimal they really are. In addition, I wanted the patches to the
> Hadoop source code itself to be clearly identifiable. So, I broke the mega
> patch up. Now, we apply the small Hadoop patch (which has been submitted to
> Hadoop trunk), COPY the Mesos contrib code over, and then apply two other
> small patches for hadoop-env.sh and mapred-site.xml.
>
> In addition, we also copy the native library into lib as well as the
> mesos.jar and protobuf.jar so that we don't need to point to any build
> directory. Likewise, we don't even need to set MESOS_NATIVE_LIBRARY at all!
> The resulting patch for hadoop-env.sh is very small indeed.
>
> I also deleted the hadoop.tar.gz that we included because I figured it would
> be just as easy to download it via the tutorial (once it's downloaded once,
> the tutorial just keeps using that, only deleting it if you do a 'make
> clean').
>
> The final directory you get after running 'make hadoop-0.20.205.0' can be
> zipped, copied, and used right away in a Mesos cluster.
>
> I also used the patch from https://issues.apache.org/jira/browse/MESOS-182 to
> do the same thing for cdh3u3. You get this via 'make hadoop-0.20.2-cdh3u3'.
>
>
> This addresses bug MESOS-182.
> https://issues.apache.org/jira/browse/MESOS-182
>
>
> Diffs
> -----
>
> Makefile.am 99a21d7
> README 0d58255
> configure.ac f1e2c3a
> ec2/Makefile.am PRE-CREATION
> hadoop/Makefile.am PRE-CREATION
> hadoop/TUTORIAL 36f5fb0
> hadoop/TUTORIAL.sh c122387
> hadoop/hadoop-0.20.2-cdh3u3.patch PRE-CREATION
> hadoop/hadoop-0.20.2-cdh3u3_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-0.20.2-cdh3u3_mesos.patch PRE-CREATION
> hadoop/hadoop-0.20.205.0.patch c113001
> hadoop/hadoop-0.20.205.0.tar.gz bc605a3
> hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 6733ef5
> hadoop/hadoop-0.20.205.0_conf_mapred-site.xml.patch 4764496
> hadoop/hadoop-0.20.205.0_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-0.20.205.0_mesos.patch PRE-CREATION
> hadoop/mapred-site.xml.patch PRE-CREATION
> hadoop/mesos-executor PRE-CREATION
> hadoop/mesos/build.xml PRE-CREATION
> hadoop/mesos/ivy.xml PRE-CREATION
> hadoop/mesos/ivy/libraries.properties PRE-CREATION
> hadoop/mesos/src/java/org/apache/hadoop/mapred/FrameworkExecutor.java
> PRE-CREATION
> hadoop/mesos/src/java/org/apache/hadoop/mapred/FrameworkScheduler.java
> PRE-CREATION
> hadoop/mesos/src/java/org/apache/hadoop/mapred/HadoopFrameworkMessage.java
> PRE-CREATION
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
> PRE-CREATION
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosTaskTrackerInstrumentation.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4922/diff
>
>
> Testing
> -------
>
> $ pwd
> /path/to/mesos/build/hadoop
> $ make hadoop-0.20.205.0
> $ make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Benjamin
>
>
