> On 2012-04-20 20:48:34, Charles Reiss wrote: > > src/webui/common/run_testcases.py, line 20 > > <https://reviews.apache.org/r/4823/diff/1/?file=103457#file103457line20> > > > > Try TestMaster or similar (unless you've integrated a coverage > > analysis).
Done renaming. > On 2012-04-20 20:48:34, Charles Reiss wrote: > > src/webui/common/run_testcases.py, line 40 > > <https://reviews.apache.org/r/4823/diff/1/?file=103457#file103457line40> > > > > Include the exception with the failure or rethrow it (and elsewhere). Done adding what Exception is thrown. > On 2012-04-20 20:48:34, Charles Reiss wrote: > > src/webui/common/webui_lib.py, line 87 > > <https://reviews.apache.org/r/4823/diff/1/?file=103459#file103459line87> > > > > I'm guessing this won't handle daylight saving transitions correctly. Should I just take out the time check then? It is not very crucial anyway to check this. > On 2012-04-20 20:48:34, Charles Reiss wrote: > > src/webui/master/index.tpl, lines 174-181 > > <https://reviews.apache.org/r/4823/diff/1/?file=103461#file103461line174> > > > > Move logic so we can do framework['max_share'] Logic is moved to webui_lib, and is stored as a list of max_shares. - terencekwt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4823/#review7091 ----------------------------------------------------------- On 2012-04-30 00:52:34, terencekwt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4823/ > ----------------------------------------------------------- > > (Updated 2012-04-30 00:52:34) > > > Review request for mesos and Charles Reiss. > > > Summary > ------- > > Python Testcases for webui > > *added unit testcases for checking if the webui could break by inputing > artificial test jsons > *should catch bugs if there syntax issues, or general cases where resources > doesn't add up correctly > *moved most of the logic out of the bottle .tpl template file and into the > common webui_lib.py > > > This addresses bug MESOS-93. > https://issues.apache.org/jira/browse/MESOS-93 > > > Diffs > ----- > > src/webui/tests/testcases.pyc PRE-CREATION > src/webui/tests/run_testcases.sh PRE-CREATION > src/webui/tests/testcases.py PRE-CREATION > src/webui/slave/index.tpl b2e2097 > src/webui/tests/run_testcases.py PRE-CREATION > src/webui/slave/executor.tpl dd53464 > src/webui/slave/framework.tpl 9488da5 > src/webui/master/framework.tpl b29d2da > src/webui/master/index.tpl 68ae313 > src/Makefile.am cd503a8 > src/webui/common/webui_lib.py 0c56fde > > Diff: https://reviews.apache.org/r/4823/diff > > > Testing > ------- > > > Thanks, > > terencekwt > >
