> On 2012-04-27 01:11:43, John Sirois wrote: > > src/common/protobuf_utils.hpp, line 52 > > <https://reviews.apache.org/r/4899/diff/2/?file=104741#file104741line52> > > > > const reference for this guy too right?
fixed > On 2012-04-27 01:11:43, John Sirois wrote: > > src/common/utils.hpp, line 190 > > <https://reviews.apache.org/r/4899/diff/2/?file=104742#file104742line190> > > > > Tests for these seem in order. IIRC there is a decent temp dir utility > > to setup files and dirs for this. added. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4899/#review7290 ----------------------------------------------------------- On 2012-04-27 01:11:30, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4899/ > ----------------------------------------------------------- > > (Updated 2012-04-27 01:11:30) > > > Review request for mesos and John Sirois. > > > Summary > ------- > > We can now read/write strings to a file. > > Some common utils for working with protobuf objects. > > > Diffs > ----- > > src/Makefile.am cd503a8 > src/common/protobuf_utils.hpp PRE-CREATION > src/common/utils.hpp 1d81e21 > src/slave/slave.cpp b233b68 > src/tests/protobuf_io_tests.cpp 22f37ac > > Diff: https://reviews.apache.org/r/4899/diff > > > Testing > ------- > > make check > > > Thanks, > > Vinod > >
