----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5014/#review7641 -----------------------------------------------------------
The code looks fine to me - I'm just not sure this is an entirely appropriate use of a libprocess process - leaving shipit to Ben src/slave/writer.cpp <https://reviews.apache.org/r/5014/#comment16852> This ties up something - I forget the current state of libprocess processes wrt os threads. Would it be better to buckle down and use aio_write or some other library that leverages asynch write support in the kernel? - John On 2012-05-04 18:38:19, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5014/ > ----------------------------------------------------------- > > (Updated 2012-05-04 18:38:19) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > A very simple libprocess writer that could be used to perform async writes. > > An user of this class could just dispatch write() calls and not be worried > about being blocked by the disk i/o. > > > Diffs > ----- > > src/Makefile.am cd503a8 > src/slave/writer.hpp PRE-CREATION > src/slave/writer.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5014/diff > > > Testing > ------- > > None > > > Thanks, > > Vinod > >
