-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5057/#review7657
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/5057/#comment16872>

    Does this new api call still transition live tasks to LOST/FAILED?



src/slave/slave.cpp
<https://reviews.apache.org/r/5057/#comment16873>

    Is there a test that could be tweaked to ensure this is happening?  
Presumably it wasn't before via executorExited?


- John


On 2012-05-07 21:11:34, Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5057/
> -----------------------------------------------------------
> 
> (Updated 2012-05-07 21:11:34)
> 
> 
> Review request for mesos, Benjamin Hindman and John Sirois.
> 
> 
> Summary
> -------
> 
> Fix for: https://issues.apache.org/jira/browse/MESOS-190
> 
> Also prevents slave from infinitely re-trying status updates to a dead 
> framework.
> 
> 
> This addresses bug MESOS-190.
>     https://issues.apache.org/jira/browse/MESOS-190
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 09a8396 
> 
> Diff: https://reviews.apache.org/r/5057/diff
> 
> 
> Testing
> -------
> 
> Checked with long lived framework.
> 
> $ ./bin/mesos-master.sh
> $ ./bin/mesos-slave.sh --master=localhost:5050
> $./src/long-lived-framework localhost:5050
> 
> 
> Thanks,
> 
> Vinod
> 
>

Reply via email to