> On 2012-05-15 00:23:28, John Sirois wrote: > > src/launcher/launcher.cpp, line 86 > > <https://reviews.apache.org/r/5115/diff/1/?file=108937#file108937line86> > > > > Maybe a sep. CL, but this begs the question - should std{out,err} be > > closed by root here then reopened by user below such that the resulting > > std{out,err} files are owned by user? Afaict this relies on a sane umask > > for the user to be able to inspect their stream files. > > Benjamin Hindman wrote: > Wouldn't just moving this below switchUser be sufficient?
Yes - it may be. If so - lgtm - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5115/#review7878 ----------------------------------------------------------- On 2012-05-15 00:17:20, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5115/ > ----------------------------------------------------------- > > (Updated 2012-05-15 00:17:20) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > src/launcher/launcher.cpp 5c2c9e3 > > Diff: https://reviews.apache.org/r/5115/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
