> On 2012-05-21 19:06:11, Benjamin Hindman wrote: > > src/linux/cgroups.cpp, line 55 > > <https://reviews.apache.org/r/5174/diff/1/?file=109708#file109708line55> > > > > This should be configurable (because it's configurable by default > > right?).
This is like /proc/stat which I don't think it's configurable. Are you suggesting cgroups hierarchy root (which is configurable)? > On 2012-05-21 19:06:11, Benjamin Hindman wrote: > > src/linux/cgroups.hpp, line 43 > > <https://reviews.apache.org/r/5174/diff/1/?file=109707#file109707line43> > > > > Comment is not necessary. ;) But the need for a default constructor is > > a little disconcerting (more prone for bugs). Since I will put this structure in an std::map, what should I do to avoid a default constructor here? Or you don't allow structure to be put directly into an stl container (use a pointer instead)? > On 2012-05-21 19:06:11, Benjamin Hindman wrote: > > src/Makefile.am, line 195 > > <https://reviews.apache.org/r/5174/diff/1/?file=109706#file109706line195> > > > > Please wrap this line like the others. Do you know any command to do this automatically in vi? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5174/#review8015 ----------------------------------------------------------- On 2012-05-21 01:13:01, Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5174/ > ----------------------------------------------------------- > > (Updated 2012-05-21 01:13:01) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > Add a few basic functions to control linux cgroups directly. > > > Diffs > ----- > > src/Makefile.am 333234d > src/linux/cgroups.hpp PRE-CREATION > src/linux/cgroups.cpp PRE-CREATION > src/tests/cgroups_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5174/diff > > > Testing > ------- > > Very basic tests. On linux machine: make check > > > Thanks, > > Jie > >
