-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4944/
-----------------------------------------------------------
(Updated 2012-05-23 23:23:42.286812)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
ben's comments.
haven't run make check due to a compilation error, that I'm having difficulty
figuring out (help?).
Undefined symbols:
"std::basic_string<char, std::char_traits<char>, std::allocator<char> >
mesos::internal::slave::path::format<std::basic_string<char,
std::char_traits<char>, std::allocator<char> >, mesos::SlaveID,
mesos::FrameworkID, mesos::ExecutorID, int,
mesos::TaskID>(std::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>,
std::allocator<char> >, mesos::SlaveID, mesos::FrameworkID, mesos::ExecutorID,
int, mesos::TaskID)", referenced from:
mesos::internal::slave::path::PathTestFixture_format_Test::TestBody() in
mesos_tests-path_tests.o
"std::basic_string<char, std::char_traits<char>, std::allocator<char> >
mesos::internal::slave::path::format<std::basic_string<char,
std::char_traits<char>, std::allocator<char> >, mesos::SlaveID,
mesos::FrameworkID, mesos::ExecutorID>(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char,
std::char_traits<char>, std::allocator<char> >, mesos::SlaveID,
mesos::FrameworkID, mesos::ExecutorID)", referenced from:
mesos::internal::slave::path::PathTestFixture_format_Test::TestBody() in
mesos_tests-path_tests.o
ld: symbol(s) not found
Summary
-------
See summary.
This diff is based on the previous utils patch
(https://reviews.apache.org/r/4899). I still need to update that patch with
john's comments.
Added tests.
Diffs (updated)
-----
src/tests/protobuf_io_tests.cpp 22f37ac
src/tests/utils_tests.cpp 49ec107
src/tests/path_tests.cpp PRE-CREATION
src/slave/slave.hpp 08a29d8
src/slave/slave.cpp e08be3b
src/master/http.cpp f72ceb7
src/slave/path.hpp PRE-CREATION
src/slave/path.cpp PRE-CREATION
src/common/utils.hpp 1d81e21
src/Makefile.am 333234d
src/common/protobuf_utils.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/4944/diff
Testing
-------
make check
Thanks,
Vinod
