----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5201/#review8092 -----------------------------------------------------------
Ship it! src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/5201/#comment17618> Is no space between close-paren and { the style for anonymous functions? its not used elsewhere below for non-anonymous functions. src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/5201/#comment17619> It seems like this_.url should be checked as well - I assume your nice 404 traps later will not apply for a null url, this_.element is used below so will fail fast anyway so perhaps not needed src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/5201/#comment17621> consider extracting trimToLine - this block of 4 statements is used again in tail src/webui/master/static/jquery.pailer.js <https://reviews.apache.org/r/5201/#comment17620> Don't know a good word, but this does truncate on the head which is not really typical truncate. - John On 2012-05-22 23:56:32, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5201/ > ----------------------------------------------------------- > > (Updated 2012-05-22 23:56:32) > > > Review request for mesos, John Sirois and Brian Wickman. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > src/webui/master/static/jquery.pailer.js PRE-CREATION > > Diff: https://reviews.apache.org/r/5201/diff > > > Testing > ------- > > > Thanks, > > Benjamin > >
