> On 2012-05-25 20:51:52, John Sirois wrote:
> > src/scripts/killtree.sh, line 228
> > <https://reviews.apache.org/r/5239/diff/1/?file=110282#file110282line228>
> >
> >     is [[ ]] /bin/sh? I though double [[ was bash

>From the specification:
---------------------------
The following words may be recognized as reserved words on some implementations 
(when none of the characters are quoted), causing unspecified results:

[[ ]] function select
---------------------------

I'll switch the file to be /bin/bash. Thanks.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5239/#review8119
-----------------------------------------------------------


On 2012-05-25 20:43:36, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5239/
> -----------------------------------------------------------
> 
> (Updated 2012-05-25 20:43:36)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/scripts/killtree.sh 3d89cbc 
> 
> Diff: https://reviews.apache.org/r/5239/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>

Reply via email to