----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5289/#review8216 -----------------------------------------------------------
lgtm afaict. i will let someone who knows js better to give shipit. src/webui/master/static/controllers.js <https://reviews.apache.org/r/5289/#comment17765> ws src/webui/master/static/controllers.js <https://reviews.apache.org/r/5289/#comment17766> what is this for? src/webui/master/static/controllers.js <https://reviews.apache.org/r/5289/#comment17767> s/Wat/Wait/ src/webui/master/static/dashboard.js <https://reviews.apache.org/r/5289/#comment17770> whats happening here? hard to grok. probably some doc would be better. - Vinod On 2012-05-30 00:23:08, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5289/ > ----------------------------------------------------------- > > (Updated 2012-05-30 00:23:08) > > > Review request for mesos, John Sirois, Vinod Kone, and Jonathan Fuchs. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > src/webui/master/static/app.js c2570a7 > src/webui/master/static/controllers.js a73814e > src/webui/master/static/dashboard.js fa3408a > src/webui/master/static/index.html 70a5b8e > src/webui/master/static/statistics.html PRE-CREATION > > Diff: https://reviews.apache.org/r/5289/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
