-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5394/#review8409
-----------------------------------------------------------



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18091>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18090>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18092>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18093>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18094>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18095>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18096>

    Done. Will refactor the code later (using the new set stuff).



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18097>

    Totally agreed. Refactor this code later.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18098>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18099>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18100>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18101>

    Done.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/5394/#comment18102>

    Done.


- Jie Yu


On June 19, 2012, 4:52 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5394/
> -----------------------------------------------------------
> 
> (Updated June 19, 2012, 4:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Add simple utility function to control Linux control groups (cgroups).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8760f59 
>   src/linux/cgroups.hpp PRE-CREATION 
>   src/linux/cgroups.cpp PRE-CREATION 
>   src/tests/cgroups_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/5394/diff/
> 
> 
> Testing
> -------
> 
> On Linux machine, make check.
> 
> (Root permission required. It is detected automatically, thanks to the gtest 
> hack).
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to