----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5395/#review8426 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment18108> Older versions of glibc don't have eventfd. We need to wrap it if necessary. src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment18235> This is so similar to just utils::os::read that we should create another utils version that does the conversion for you (probably via std::stringstream or boost::lexical_cast). The big difference here is returning 'none' for EAGAIN, but see my comment below. src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment18238> This is great, but can we think of any other abstractions this can use to make this stuff even simpler? In particular, what about a process::io::read which handles spurious events? See this: https://reviews.apache.org/r/5567 src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment18110> virtual src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment18111> virtual src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment18237> Is this supposed to account for spurious events? Or couldn't "none" here mean EOF? - Benjamin Hindman On June 20, 2012, 6:51 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5395/ > ----------------------------------------------------------- > > (Updated June 20, 2012, 6:51 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > In cgroups, sometimes you want to be notified if some certain events happen. > For example, users may want to be notified when an out-of-memory event > happens. > > This patch introduce a function called "listenEvent" which returns an > instance of Future so that you can check the status of this future to see > whether any event happens. > > This interface is general to all the events in cgroups. > > > Diffs > ----- > > src/linux/cgroups.hpp PRE-CREATION > src/linux/cgroups.cpp PRE-CREATION > src/tests/cgroups_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5395/diff/ > > > Testing > ------- > > On Linux machines, make check. > > > Thanks, > > Jie Yu > >
