-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5532/#review8667
-----------------------------------------------------------



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/5532/#comment18330>

    '{' on newline please.



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/5532/#comment18329>

    '{' on newline please.



src/tests/utils.hpp
<https://reviews.apache.org/r/5532/#comment18327>

    s/_)/_))/



src/tests/utils.hpp
<https://reviews.apache.org/r/5532/#comment18328>

    const & instead of just const.


- Benjamin Hindman


On June 27, 2012, 7:55 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5532/
> -----------------------------------------------------------
> 
> (Updated June 27, 2012, 7:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> Added tests for allocators.
> 
> This patch depends on two other currently pending review requests:
> https://reviews.apache.org/r/5448/
> https://reviews.apache.org/r/5451/
> 
> 
> This addresses bug MESOS-224.
>     https://issues.apache.org/jira/browse/MESOS-224
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8760f59 
>   src/tests/allocator_tests.cpp PRE-CREATION 
>   src/tests/base_zookeeper_test.hpp 4613376 
>   src/tests/resource_offers_tests.cpp c1f1760 
>   src/tests/utils.hpp e81ec82 
>   src/tests/utils.cpp e7cda40 
> 
> Diff: https://reviews.apache.org/r/5532/diff/
> 
> 
> Testing
> -------
> 
> make check on Lion
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>

Reply via email to