----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5395/#review8780 -----------------------------------------------------------
src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5395/#comment18582> Seeing this used again makes me think that there should really be a second test fixture, one where the body of 'prepare' is inside SetUp and one where it doesn't exist. Thoughts? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5395/#comment18580> Put the value expected first (here and others below). src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5395/#comment18579> Kill newline. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5395/#comment18584> Making 'size' be in terms of 'limit' is more robust. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5395/#comment18583> Space after '(char*)' please. - Benjamin Hindman On June 29, 2012, 12:47 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5395/ > ----------------------------------------------------------- > > (Updated June 29, 2012, 12:47 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > In cgroups, sometimes you want to be notified if some certain events happen. > For example, users may want to be notified when an out-of-memory event > happens. > > This patch introduce a function called "listenEvent" which returns an > instance of Future so that you can check the status of this future to see > whether any event happens. > > This interface is general to all the events in cgroups. > > > Diffs > ----- > > src/linux/cgroups.hpp PRE-CREATION > src/linux/cgroups.cpp PRE-CREATION > src/tests/cgroups_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5395/diff/ > > > Testing > ------- > > On Linux machines, make check. > > > Thanks, > > Jie Yu > >
