----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5863/ -----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone. Description ------- After converting some things over to use the new flags abstraction, I realized that I didn't provide everything I really wanted, so I refactored it a bit. This is really the "flags" abstraction review. Diffs ----- src/Makefile.am 11f6b4c src/configurator/configurator.hpp 8569645 src/flags/flag.hpp PRE-CREATION src/flags/flags.hpp PRE-CREATION src/flags/loader.hpp PRE-CREATION src/logging/flags.hpp PRE-CREATION src/logging/logging.hpp PRE-CREATION src/logging/logging.cpp PRE-CREATION src/master/flags.hpp PRE-CREATION src/master/http.cpp 82784fb src/master/main.cpp bcbe35a src/master/master.hpp 886f79c src/master/master.cpp 44a5dc6 src/master/webui.hpp 660d5e1 src/master/webui.cpp 56134b7 src/tests/flags_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/5863/diff/ Testing ------- make check Thanks, Benjamin Hindman
