----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5867/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Description ------- Refactor the code to separate libstout. The initial changes include option.hpp, try.hpp and result.hpp. Diffs ----- src/Makefile.am 11f6b4c src/common/attributes.hpp b773f74 src/common/cache.hpp cfe234e src/common/format.hpp 0b1e203 src/common/hashmap.hpp 50a1b74 src/common/option.hpp 1ec2f7e src/common/resources.hpp d94c553 src/common/resources.cpp 23993e5 src/common/result.hpp 0f429a5 src/common/try.hpp ed5611b src/common/utils.hpp c8bdccf src/common/values.hpp babf5ba src/configurator/configuration.hpp d529917 src/detector/detector.hpp 95e9a31 src/linux/fs.hpp fa4e4a8 src/linux/proc.hpp ee25d73 src/linux/proc.cpp d39ad3c src/log/coordinator.hpp f77287e src/log/log.hpp 23f3d62 src/log/log.cpp 283054e src/log/replica.hpp 6361f27 src/master/frameworks_manager.hpp eea1ffc src/master/http.cpp 82784fb src/master/main.cpp bcbe35a src/slave/main.cpp c08a55d src/slave/slave.cpp 743e81c src/slave/webui.cpp 5616542 src/state/leveldb.cpp a0ce822 src/state/state.hpp d8788ca src/state/zookeeper.cpp c82b8a3 src/tests/fs_tests.cpp ffc25d7 src/tests/log_tests.cpp d9bfa1a src/tests/master_detector_tests.cpp 4cefbfa src/tests/proc_tests.cpp b9dcb91 src/tests/state_tests.cpp ca1180e src/tests/values_tests.cpp 3c110ea src/tests/zookeeper_url_tests.cpp 2128fd1 src/zookeeper/group.hpp d14af06 src/zookeeper/group.cpp 74bfb3c src/zookeeper/url.hpp 3823901 third_party/libprocess/Makefile.am aba8b7c third_party/libprocess/include/process/collect.hpp 7e3467f third_party/libprocess/include/process/future.hpp 1aa8ffd third_party/libprocess/include/process/option.hpp 5c4b1a4 third_party/libprocess/include/stout/option.hpp PRE-CREATION third_party/libprocess/include/stout/result.hpp PRE-CREATION third_party/libprocess/include/stout/try.hpp PRE-CREATION Diff: https://reviews.apache.org/r/5867/diff/ Testing ------- make check. Tested on mac and linux. Thanks, Jie Yu
