----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5896/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Description ------- This patch factors out libstout in libprocess/include/stout. This patch should not affect any code in mesos. Most of the code are copied from src/common, with the following exceptions: 1) re-write utils::os::rmdir to make it inline-able. 2) inline functions in fatal.hpp. 3) change #include in every file accordingly. Tests are also pulled out and put into src/tests/stout_tests.cpp (I put it in mesos directory so that I don't need to change the libprocess makefile drastically.) Diffs ----- src/Makefile.am e418bca src/tests/stout_tests.cpp PRE-CREATION third_party/libprocess/Makefile.am aba8b7c third_party/libprocess/include/stout/cache.hpp PRE-CREATION third_party/libprocess/include/stout/fatal.hpp PRE-CREATION third_party/libprocess/include/stout/foreach.hpp PRE-CREATION third_party/libprocess/include/stout/format.hpp PRE-CREATION third_party/libprocess/include/stout/hashmap.hpp PRE-CREATION third_party/libprocess/include/stout/hashset.hpp PRE-CREATION third_party/libprocess/include/stout/json.hpp PRE-CREATION third_party/libprocess/include/stout/lambda.hpp PRE-CREATION third_party/libprocess/include/stout/multihashmap.hpp PRE-CREATION third_party/libprocess/include/stout/net.hpp PRE-CREATION third_party/libprocess/include/stout/option.hpp PRE-CREATION third_party/libprocess/include/stout/os.hpp PRE-CREATION third_party/libprocess/include/stout/protobuf.hpp PRE-CREATION third_party/libprocess/include/stout/result.hpp PRE-CREATION third_party/libprocess/include/stout/stringify.hpp PRE-CREATION third_party/libprocess/include/stout/strings.hpp PRE-CREATION third_party/libprocess/include/stout/time.hpp PRE-CREATION third_party/libprocess/include/stout/timer.hpp PRE-CREATION third_party/libprocess/include/stout/try.hpp PRE-CREATION third_party/libprocess/include/stout/uuid.hpp PRE-CREATION Diff: https://reviews.apache.org/r/5896/diff/ Testing ------- make check Tested on both mac and linux. Thanks, Jie Yu
