----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5865/#review9078 -----------------------------------------------------------
include/mesos/scheduler.hpp <https://reviews.apache.org/r/5865/#comment19220> you generally call out forward declarations src/master/webui.hpp <https://reviews.apache.org/r/5865/#comment19221> kill trailing ws src/sched/sched.cpp <https://reviews.apache.org/r/5865/#comment19222> what does this mean? src/sched/sched.cpp <https://reviews.apache.org/r/5865/#comment19223> s/fromt/from/ src/slave/lxc_isolation_module.cpp <https://reviews.apache.org/r/5865/#comment19224> join src/slave/main.cpp <https://reviews.apache.org/r/5865/#comment19225> seems worth Option<short> and convert back to string for the env var to leverage the type check src/slave/slave.hpp <https://reviews.apache.org/r/5865/#comment19226> join src/slave/slave.cpp <https://reviews.apache.org/r/5865/#comment19227> join - John Sirois On July 9, 2012, 10:27 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5865/ > ----------------------------------------------------------- > > (Updated July 9, 2012, 10:27 p.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > In particular, integration with slave and scheduler. > > > Diffs > ----- > > include/mesos/scheduler.hpp c307b28 > src/Makefile.am 11f6b4c > src/flags/flags.hpp PRE-CREATION > src/local/local.hpp 55f9eaf > src/local/local.cpp d35639f > src/logging/flags.hpp PRE-CREATION > src/master/flags.hpp PRE-CREATION > src/master/main.cpp bcbe35a > src/master/webui.hpp 660d5e1 > src/master/webui.cpp 56134b7 > src/sched/sched.cpp dc91154 > src/slave/flags.hpp PRE-CREATION > src/slave/http.cpp 4a7057a > src/slave/isolation_module.hpp c896908 > src/slave/lxc_isolation_module.hpp b7beefe > src/slave/lxc_isolation_module.cpp 2ff1e9c > src/slave/main.cpp c08a55d > src/slave/process_based_isolation_module.hpp f6f9554 > src/slave/process_based_isolation_module.cpp 692ad40 > src/slave/slave.hpp 80453b0 > src/slave/slave.cpp 743e81c > src/slave/webui.hpp cb15ac6 > src/slave/webui.cpp 5616542 > src/tests/flags_tests.cpp PRE-CREATION > src/tests/slave_tests.cpp 84e8e7d > src/tests/utils.hpp e81ec82 > > Diff: https://reviews.apache.org/r/5865/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
