> On July 11, 2012, 6:34 p.m., John Sirois wrote: > > src/local/main.cpp, line 73 > > <https://reviews.apache.org/r/5866/diff/1/?file=120882#file120882line73> > > > > Seems best to use short for validation, convert to string for env var
Done. > On July 11, 2012, 6:34 p.m., John Sirois wrote: > > src/log/main.cpp, line 75 > > <https://reviews.apache.org/r/5866/diff/1/?file=120883#file120883line75> > > > > It would be nice to build a help flag into the lib at some point, maybe > > flags.load could have an overload that takes the usage string or there > > couls be an explicit flags.enable_help(usage) or flags.set_usage(usage) or > > a constructor overload that takes the usage message. > > > > Maybe an overload to pass the Yeah. I'll be pulling more stuff out of Configurator/Configuration that will do exactly this stuff. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5866/#review9079 ----------------------------------------------------------- On July 9, 2012, 10:29 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5866/ > ----------------------------------------------------------- > > (Updated July 9, 2012, 10:29 p.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > At this point, Configurator and Configuration is only used to "load" options > from the command line, environment, and configuration files (expect for > local::launch). > > > Diffs > ----- > > src/Makefile.am 11f6b4c > src/local/flags.hpp PRE-CREATION > src/local/local.hpp 55f9eaf > src/local/local.cpp d35639f > src/local/main.cpp 4d59ab1 > src/log/main.cpp d9c7f28 > src/logging/logging.hpp PRE-CREATION > src/logging/logging.cpp PRE-CREATION > src/master/main.cpp bcbe35a > src/sched/sched.cpp dc91154 > src/tests/flags_tests.cpp PRE-CREATION > src/tests/main.cpp 7cebe0e > > Diff: https://reviews.apache.org/r/5866/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
