-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5854/#review9090
-----------------------------------------------------------

Ship it!


Ship It!

- John Sirois


On July 9, 2012, 10:01 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5854/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 10:01 p.m.)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Description
> -------
> 
> The first of 13 reviews related to replacing configuration in Mesos with a 
> "flags" abstraction. In particular, the flags abstraction:
> 
> (1) Eliminates the need to specify defaults in more than one place.
> (2) Eliminates the need to specify types for options in more than one place.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 11f6b4c 
>   src/common/strings.hpp fbca257 
>   src/flags/flags.hpp PRE-CREATION 
>   src/tests/flags_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/5854/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to