----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5845/#review9184 -----------------------------------------------------------
Ship it! third_party/libprocess/include/process/collect.hpp <https://reviews.apache.org/r/5845/#comment19660> why do u need to copy the future and return it here? is promise being deleted inside the CollectProcess? - Vinod Kone On July 10, 2012, 6:45 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5845/ > ----------------------------------------------------------- > > (Updated July 10, 2012, 6:45 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > A memory leak is possible in process::collect if the timeout is none and some > of the futures return failure. > > > Diffs > ----- > > third_party/libprocess/include/process/collect.hpp 7e3467f > > Diff: https://reviews.apache.org/r/5845/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
