----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5401/#review9401 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/5401/#comment20137> What's the benefit of returning a string over just a bool? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5401/#comment20138> There are lots of timing related things in this test which could make them fail non-deterministically on peoples machines. I'd much prefer to have these tests run deterministically so as not to try and debug a remote persons "make check is failing" complaint only find out it's because they are trying to watch a movie when running the tests and the timings are working out. Consider using a pipe to signal when child/parent should do things. - Benjamin Hindman On July 16, 2012, 6:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5401/ > ----------------------------------------------------------- > > (Updated July 16, 2012, 6:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This patch provides APIs for controlling the cgroups freezer subsystem. > > It is very useful when a slave wants to kill/pause all the processes in (or > forked by) an executor. > > For example, when an out-of-memory event happens, the slave could choose 1) > kill the executor, 2) pause the executor and notify the user, and so on. > > > Diffs > ----- > > src/linux/cgroups.hpp cec9e36 > src/linux/cgroups.cpp 93c140f > src/tests/cgroups_tests.cpp 7f0f901 > > Diff: https://reviews.apache.org/r/5401/diff/ > > > Testing > ------- > > On Linux machine, make check. > > > Thanks, > > Jie Yu > >
