> On Aug. 9, 2012, 7:52 p.m., Jie Yu wrote: > > src/state/serializer.hpp, line 38 > > <https://reviews.apache.org/r/6499/diff/1/?file=136500#file136500line38> > > > > Can we replace that with a static_cast?
replaced, still need a (void) on there to silence 'statement with no effect' warning. > On Aug. 9, 2012, 7:52 p.m., Jie Yu wrote: > > src/tests/utils.hpp, line 160 > > <https://reviews.apache.org/r/6499/diff/1/?file=136513#file136513line160> > > > > It's misleading, I would say change that. done - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6499/#review10083 ----------------------------------------------------------- On Aug. 9, 2012, 10:36 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6499/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2012, 10:36 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu. > > > Description > ------- > > Also, be sure to see my TODO in src/tests/utils.hpp > > > This addresses bug MESOS-253. > https://issues.apache.org/jira/browse/MESOS-253 > > > Diffs > ----- > > src/Makefile.am 75f8083 > src/common/attributes.cpp 77be97c > src/common/resources.cpp 7b410ff > src/common/values.cpp 957c413 > src/configurator/configurator.cpp 135fbd2 > src/configurator/option.hpp 6982ec3 > src/examples/balloon_framework.cpp 045ba08 > src/examples/long_lived_framework.cpp 369975b > src/examples/no_executor_framework.cpp b5f4ff9 > src/examples/test_framework.cpp 7e0c2e2 > src/exec/exec.cpp c9f87fa > src/java/jni/convert.cpp 9f52ca8 > src/jvm/jvm.cpp 0e3614d > src/launcher/launcher.cpp 35cc6dd > src/local/local.cpp 42dbf06 > src/log/coordinator.hpp d585b7d > src/log/coordinator.cpp 838852f > src/log/log.hpp dcbf0b1 > src/master/constants.hpp 9214bab > src/master/master.hpp d21ff3c > src/master/master.cpp 4f62687 > src/sched/sched.cpp a147e90 > src/slave/slave.hpp 7e860e1 > src/slave/slave.cpp c8374b1 > src/state/serializer.hpp 8b28408 > src/tests/allocator_tests.cpp b3db13d > src/tests/attributes_tests.cpp 1e87d923 > src/tests/exception_tests.cpp d0d17c4 > src/tests/fault_tolerance_tests.cpp f892282 > src/tests/flags_tests.cpp 1372b0a > src/tests/log_tests.cpp 9397da4 > src/tests/master_tests.cpp b586984 > src/tests/multihashmap_tests.cpp c399362 > src/tests/resource_offers_tests.cpp c004772 > src/tests/resources_tests.cpp 897422f > src/tests/slave_tests.cpp c190666 > src/tests/stout_tests.cpp 0cb39b9 > src/tests/utils.hpp a768360 > src/tests/zookeeper_tests.cpp 7336705 > src/webui/webui.cpp 1849ef0 > src/zookeeper/group.cpp 8ae23f3 > src/zookeeper/url.hpp d6d4750 > src/zookeeper/zookeeper.cpp 621deaf > third_party/libprocess/include/process/protobuf.hpp 6dad48b > third_party/libprocess/include/stout/cache.hpp 8a7c332 > third_party/libprocess/include/stout/os.hpp 4b1e368 > third_party/libprocess/include/stout/strings.hpp 5bf0489 > third_party/libprocess/include/stout/time.hpp 46d7077 > > Diff: https://reviews.apache.org/r/6499/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Ben Mahler > >
