> On Aug. 10, 2012, 3:06 a.m., Benjamin Hindman wrote: > > src/webui/master/static/framework.html, line 51 > > <https://reviews.apache.org/r/6503/diff/1/?file=136787#file136787line51> > > > > Why not 'number:2' on all of these? > > Ben Mahler wrote: > Would you prefer that? I just preferred the following behavior: > 12.333333 -> 12.333 > 12.1 -> 12.1 > 12 -> 12 > > vs number:2 > 12.333333 -> 12.33 > 12.1 -> 12.10 > 12 -> 12.00 > > Since cpu numbers were often non-fractional, but I'll change it if you > like :)
Oh no, I like number better. Should we change the other ones to just number too? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6503/#review10104 ----------------------------------------------------------- On Aug. 9, 2012, 11:51 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6503/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2012, 11:51 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > This prevents the huge decimal glitchy-ness in the cpu numbers (by maxing out > at 3 decimal places). > > > Diffs > ----- > > src/webui/master/static/framework.html 0c4038b > src/webui/master/static/frameworks.html cc4835f > src/webui/master/static/home.html f3a3d0a > src/webui/master/static/slaves.html efff0ac > > Diff: https://reviews.apache.org/r/6503/diff/ > > > Testing > ------- > > local webui runs > > > Thanks, > > Ben Mahler > >
