----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5913/#review10370 -----------------------------------------------------------
Ship it! src/tests/sorter_tests.cpp <https://reviews.apache.org/r/5913/#comment22042> Use foreach if you can, otherwise, put a space around '!='. src/tests/sorter_tests.cpp <https://reviews.apache.org/r/5913/#comment22043> Newline. src/tests/sorter_tests.cpp <https://reviews.apache.org/r/5913/#comment22041> Just put on stack. - Benjamin Hindman On Aug. 14, 2012, 12:03 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5913/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 12:03 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > The old AllocatorTests were renamed AllocatorProcessTests to reflect the > restructuring of the allocator code. There are now new AllocatorTests which > test the new Allocator classes by instantiating them, passing them arbitrary > elements with different resources allocated to them, and then checks that it > returns the right thing. > > This patch depends on another pending code review: > https://reviews.apache.org/r/5599/ > > > Diffs > ----- > > src/Makefile.am b0cb6cc > src/tests/sorter_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5913/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Marshall > >
