----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6649/#review10401 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/6649/#comment22151> The comment used to refer to sequential lines so maybe it aided reading for high level steps - now it does not do that, consider just killing. - John Sirois On Aug. 16, 2012, 7:59 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6649/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 7:59 a.m.) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Description > ------- > > See summary > > > This addresses bug MESOS-257. > https://issues.apache.org/jira/browse/MESOS-257 > > > Diffs > ----- > > src/master/dominant_share_allocator.cpp 17c38f0 > src/master/master.hpp d21ff3c > src/master/master.cpp 0eca2fa > src/tests/master_tests.cpp b586984 > src/tests/utils.hpp caf5926 > > Diff: https://reviews.apache.org/r/6649/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
