----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6755/#review10770 -----------------------------------------------------------
Ship it! third_party/libprocess/include/stout/time.hpp <https://reviews.apache.org/r/6755/#comment23229> Is there a unit test for parse? third_party/libprocess/include/stout/time.hpp <https://reviews.apache.org/r/6755/#comment23228> semicolon bonanza from here down in return Times - John Sirois On Aug. 24, 2012, 10:56 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6755/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 10:56 p.m.) > > > Review request for mesos, Benjamin Hindman, John Sirois, and Ben Mahler. > > > Description > ------- > > This is inspired by John's Time implementation in science. > > I didn't include conversions from one instance to another (e.g Seconds to > Minutes), because I think its not needed. Everything would be passed as Time > objects. > > > This addresses bug MESOS-260. > https://issues.apache.org/jira/browse/MESOS-260 > > > Diffs > ----- > > src/detector/detector.cpp 2a672b8 > src/java/jni/org_apache_mesos_Log.cpp 3928b31 > src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 1f46e08 > src/linux/cgroups.hpp 5391c22 > src/log/coordinator.hpp d585b7d > src/log/log.hpp dcbf0b1 > src/log/network.hpp b25e995 > src/logging/logging.cpp 6909b0b > src/master/frameworks_manager.hpp 3f232e7 > src/master/frameworks_manager.cpp 6973389 > src/master/slaves_manager.cpp e25efd0 > src/slave/gc.hpp 6704742 > src/slave/gc.cpp 9c01024 > src/slave/slave.cpp 4efd41e > src/state/zookeeper.hpp cc4e9af > src/state/zookeeper.cpp a8664ac > src/tests/base_zookeeper_test.hpp 5c6f87a > src/tests/base_zookeeper_test.cpp b29171b > src/tests/gc_tests.cpp 68f6e53 > src/tests/log_tests.cpp 85b2329 > src/tests/master_tests.cpp 36dd6a0 > src/tests/stout_tests.cpp 91bcc13 > src/zookeeper/group.hpp 8b3d71b > src/zookeeper/group.cpp 8ae23f3 > src/zookeeper/zookeeper.hpp d0a76ad > src/zookeeper/zookeeper.cpp 621deaf > third_party/libprocess/include/process/statistics.hpp 7507a7b > third_party/libprocess/include/stout/time.hpp 46d7077 > third_party/libprocess/include/stout/timer.hpp 15c91b3 > third_party/libprocess/src/statistics.cpp d05b327 > third_party/libprocess/src/statistics_tests.cpp ddcf2d3 > > Diff: https://reviews.apache.org/r/6755/diff/ > > > Testing > ------- > > Not yet > > > Thanks, > > Vinod Kone > >
