----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6836/#review10875 -----------------------------------------------------------
Ship it! Mode potential flag using customer breaks this lgtm src/master/flags.hpp <https://reviews.apache.org/r/6836/#comment23435> Is this a breaking change for customers or are new Flags post 0.9 pre next? Same issue with all the Duration flags in this review. - John Sirois On Aug. 29, 2012, 6:34 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6836/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 6:34 p.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/exec/exec.cpp c9f87fa > src/flags/parse.hpp PRE-CREATION > src/master/flags.hpp 6f450d5 > src/master/hierarchical_allocator_process.hpp 86c9b1e > src/slave/constants.hpp ab83972 > src/slave/flags.hpp 0c7917f > src/slave/slave.cpp 4efd41e > src/tests/flags_tests.cpp 1372b0a > src/tests/gc_tests.cpp 68f6e53 > third_party/libprocess/include/stout/duration.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/6836/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
