> On Sept. 10, 2012, 6:11 p.m., John Sirois wrote: > > The boost change is an application of the patch here found by Ben Mahler: > > https://svn.boost.org/trac/boost/ticket/6854 > > Ben Mahler wrote: > great!! > > any idea why the test failed? > also, review board eats the binary part of the diff, so you may want to > additionally attach a binary diff via 'git diff --binary'
Sure - you assume a universal linux mount arrangement and that won't work in general: [jsirois@gill build] (jsirois/MESOS-271) $ ./bin/mesos-tests.sh --gtest_filter=FsTest.FileSystemTableRead Source directory: /home/jsirois/development/3rdparty/mesos Build directory: /home/jsirois/development/3rdparty/mesos/build Note: Google Test filter = FsTest.FileSystemTableRead-:CgroupsIsolation.ROOT_CGROUPS_BalloonFramework:CgroupsSimpleTest.ROOT_CGROUPS_Enabled:CgroupsSimpleTest.ROOT_CGROUPS_Subsystems:CgroupsSimpleTest.ROOT_CGROUPS_CreateRemoveHierarchy:CgroupsSimpleTest.ROOT_CGROUPS_CreateRemoveCgroup:CgroupsTest.ROOT_CGROUPS_Busy:CgroupsTest.ROOT_CGROUPS_SubsystemsHierarchy:CgroupsTest.ROOT_CGROUPS_CheckHierarchy:CgroupsTest.ROOT_CGROUPS_CheckHierarchySubsystems:CgroupsTest.ROOT_CGROUPS_ReadControl:CgroupsTest.ROOT_CGROUPS_WriteControl:CgroupsTest.ROOT_CGROUPS_GetCgroups:CgroupsTest.ROOT_CGROUPS_GetTasks:CgroupsTest.ROOT_CGROUPS_ListenEvent:CgroupsTest.ROOT_CGROUPS_Freezer:CgroupsTest.ROOT_CGROUPS_KillTasks:CgroupsTest.ROOT_CGROUPS_DestroyCgroup [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from FsTest [ RUN ] FsTest.FileSystemTableRead ../../src/tests/fs_tests.cpp:93: Failure Value of: proc.isSome() Actual: false Expected: true [ FAILED ] FsTest.FileSystemTableRead (1 ms) [----------] 1 test from FsTest (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] FsTest.FileSystemTableRead 1 FAILED TEST YOU HAVE 6 DISABLED TESTS ^[jsirois@gill build] (jsirois/MESOS-271) $ cat /etc/fstab # # /etc/fstab # Created by anaconda on Sun Sep 2 17:26:30 2012 # # Accessible filesystems, by reference, are maintained under '/dev/disk' # See man pages fstab(5), findfs(8), mount(8) and/or blkid(8) for more info # /dev/mapper/vg_gill-lv_root / ext4 defaults 1 1 UUID=c5efcb24-494f-49fd-9cf8-323ef4f47fdc /boot ext4 defaults 1 2 /dev/mapper/vg_gill-lv_home /home ext4 defaults 1 2 /dev/mapper/vg_gill-lv_swap swap swap defaults 0 0 - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6988/#review11258 ----------------------------------------------------------- On Sept. 10, 2012, 6:10 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6988/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 6:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > commit 2e1404f2630c561e586c6eb488f71d26ede1b4c7 > Author: jsirois <[email protected]> > Date: Mon Sep 10 14:01:26 2012 -0400 > > Get mesos compiling under gcc-4.7 > > src/examples/long_lived_executor.cpp | 1 + > third_party/boost-1.51.0.tar.gz | Bin 7203699 -> > 7469124 bytes > third_party/libprocess/include/process/protobuf.hpp | 2 +- > third_party/libprocess/include/stout/multihashmap.hpp | 17 ++++++++++------- > 4 files changed, 12 insertions(+), 8 deletions(-) > > > This addresses bug MESOS-271. > https://issues.apache.org/jira/browse/MESOS-271 > > > Diffs > ----- > > src/examples/long_lived_executor.cpp bb38873 > third_party/boost-1.51.0.tar.gz e461b8a > third_party/libprocess/include/process/protobuf.hpp 5911c59 > third_party/libprocess/include/stout/multihashmap.hpp 6d324d4 > > Diff: https://reviews.apache.org/r/6988/diff/ > > > Testing > ------- > > [jsirois@gill build] (jsirois/MESOS-271) $ gcc --version > gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5) > Copyright (C) 2012 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > [jsirois@gill build] (jsirois/MESOS-271) $ make check > ... > [ OK ] AllocatorZooKeeperTest/0.SlaveReregisterFirst (1452 ms) > [----------] 2 tests from AllocatorZooKeeperTest/0 (3622 ms total) > > [----------] Global test environment tear-down > [==========] 180 tests from 36 test cases ran. (92375 ms total) > [ PASSED ] 179 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] FsTest.FileSystemTableRead > > 1 FAILED TEST > YOU HAVE 6 DISABLED TESTS > > FAIL: mesos-tests > ================== > 1 of 1 test failed > ================== > make[3]: *** [check-TESTS] Error 1 > make[3]: Leaving directory > `/home/jsirois/development/3rdparty/mesos/build/src' > make[2]: *** [check-am] Error 2 > make[2]: Leaving directory > `/home/jsirois/development/3rdparty/mesos/build/src' > make[1]: *** [check] Error 2 > make[1]: Leaving directory > `/home/jsirois/development/3rdparty/mesos/build/src' > make: *** [check-recursive] Error 1 > > > Thanks, > > John Sirois > >
