----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7008/#review11334 -----------------------------------------------------------
src/tests/logging_tests.cpp <https://reviews.apache.org/r/7008/#comment24353> hm.. I see why you did this, no simple/clean way to not hardcode this src/tests/logging_tests.cpp <https://reviews.apache.org/r/7008/#comment24354> I missed some BadRequest tests in files do you mind adding some tests in files? read.json without 'path=...' read.json with un-parseable 'length=...' read.json with un-parseable 'offset=...' browse.json without 'path=...' if you don't want to bundle that in this CL, let me know and I'll follow up on this one src/tests/utils.hpp <https://reviews.apache.org/r/7008/#comment24355> nice catch src/tests/zookeeper_tests.cpp <https://reviews.apache.org/r/7008/#comment24356> this is great cleanup! third_party/libprocess/include/process/process.hpp <https://reviews.apache.org/r/7008/#comment24357> one line? P.S. I haven't noticed these javadoc style comments: /** * @param foo ... */ Do you still encourage commenting in this manner? - Ben Mahler On Sept. 11, 2012, 5:44 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7008/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 5:44 a.m.) > > > Review request for mesos and Ben Mahler. > > > Description > ------- > > Used new ASSERT/EXPECT_FUTURE_* within some existing tests as well as added > ASSERT/EXPECT_FUTURE_WILL_EQ and EXPECT_RESPONSE_BODY_WILL_EQ. Also added new > tests for logging HTTP interface thanks to process::http::get. > > > Diffs > ----- > > src/Makefile.am b73a024 > src/tests/files_tests.cpp 6ef2004 > src/tests/logging_tests.cpp PRE-CREATION > src/tests/utils.hpp 79999b5 > src/tests/zookeeper_tests.cpp 19c2dfa > third_party/libprocess/include/process/process.hpp 76da79b > third_party/libprocess/src/process.cpp 2d2b56c > > Diff: https://reviews.apache.org/r/7008/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
