----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7006/#review11337 -----------------------------------------------------------
looks great, feel free to change offset/length parsing in FilesProcess::read as well :) src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24367> pass in the error string directly? src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24368> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24369> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24370> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24371> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24372> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24373> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24374> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24375> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24361> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24366> too bad we don't have tests for this stuff :) src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24364> ditto src/master/slaves_manager.cpp <https://reviews.apache.org/r/7006/#comment24365> ditto - Ben Mahler On Sept. 11, 2012, 5:41 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7006/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 5:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/slaves_manager.cpp 7a3f110 > third_party/libprocess/include/stout/numify.hpp e13d710 > > Diff: https://reviews.apache.org/r/7006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
