----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6842/#review11341 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/6842/#comment24377> this breaks the line alignment, put it after slave/gc.cpp? src/Makefile.am <https://reviews.apache.org/r/6842/#comment24378> This also doesn't align, looks like someone used tabs for the end of line \ alignment, where tabs were treated as... 8 spaces! I don't see why we didn't just do 1 file per line in our makefiles.. seems harder for humans to read this way anyway, feel free to ignore this :) src/Makefile.am <https://reviews.apache.org/r/6842/#comment24379> ditto on the alignment third_party/libprocess/include/stout/format.hpp <https://reviews.apache.org/r/6842/#comment24388> what happened here? third_party/libprocess/include/stout/format.hpp <https://reviews.apache.org/r/6842/#comment24387> one idea: store t as a const& then in get(), do the stringify(t).c_str() third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/6842/#comment24386> comment on what this and mkdtemp returns third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/6842/#comment24383> instead of const_cast, could we just use strcpy into a non-const char* instead? third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/6842/#comment24384> ditto third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/6842/#comment24380> add a comment about returning Result::none on no match third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/6842/#comment24381> ++i :) - Ben Mahler On Aug. 29, 2012, 11:09 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6842/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 11:09 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > And so it begins... > > I am discarding the old review associated with this (previously called path: > https://reviews.apache.org/r/4944/), in favor of a fresh start. > > slave/state.{hpp,cpp} contains all the functions that deal with persistent > state of the slave. > > > This addresses bug MESOS-110. > https://issues.apache.org/jira/browse/MESOS-110 > > > Diffs > ----- > > src/Makefile.am aaceee3 > src/common/protobuf_utils.hpp PRE-CREATION > src/slave/slave.hpp 10c537b > src/slave/slave.cpp 4efd41e > src/slave/state.hpp PRE-CREATION > src/slave/state.cpp PRE-CREATION > src/tests/slave_state_tests.cpp PRE-CREATION > third_party/libprocess/include/stout/format.hpp c746ad3 > third_party/libprocess/include/stout/os.hpp b1eceb3 > > Diff: https://reviews.apache.org/r/6842/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
