----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7061/#review11548 -----------------------------------------------------------
src/logging/logging.hpp <https://reviews.apache.org/r/7061/#comment24812> I wonder if the right thing to do here is actually just expose argv0 somewhere (maybe not logging specific) and then do 'os::basename(argv0) + suffix' when you want to get the log name. Note as well that "basename" typically refers to the right most suffix, so basename(/foo/bar/baz.txt) => baz.txt and basename(baz.txt) => txt. src/master/master.cpp <https://reviews.apache.org/r/7061/#comment24813> How about attaching at /master/log since we might be attaching more things under master in the future and I could see a desire to "browse" them at some point. src/slave/slave.cpp <https://reviews.apache.org/r/7061/#comment24814> Ditto above. - Benjamin Hindman On Sept. 12, 2012, 9:50 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7061/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 9:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This eliminates the hard-coding of the log filenames: mesos-master.INFO and > mesos-slave.INFO. > > > Diffs > ----- > > src/logging/logging.hpp 9dcc7c1 > src/logging/logging.cpp d6d31ec > src/master/master.cpp addabdb > src/slave/slave.cpp 4ea1db1 > src/webui/master/static/controllers.js 41cec18 > > Diff: https://reviews.apache.org/r/7061/diff/ > > > Testing > ------- > > make check > mesos-local.sh runs > > > Thanks, > > Ben Mahler > >
