----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7133/#review11623 -----------------------------------------------------------
Ship it! src/tests/tests.proto <https://reviews.apache.org/r/7133/#comment25088> why are these required? also, can you group all 'required' field together? - Vinod Kone On Sept. 17, 2012, 5:37 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7133/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 5:37 p.m.) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Description > ------- > > This adds Proto->JSON conversion using the protobuf Reflection API. > This should help remove a lot of the json building boilerplate we have in our > */http.cpp files. > > Note that strings::join has already been reviewed in a pending CL: > https://reviews.apache.org/r/6739/diff/?page=2 > > > This addresses bug MESOS-269. > https://issues.apache.org/jira/browse/MESOS-269 > > > Diffs > ----- > > src/Makefile.am b73a024 > src/tests/stout_tests.cpp f690fac > src/tests/tests.proto PRE-CREATION > third_party/libprocess/include/stout/json.hpp 1c66dfd > third_party/libprocess/include/stout/protobuf.hpp d2b5dae > third_party/libprocess/include/stout/strings.hpp aca0b02 > > Diff: https://reviews.apache.org/r/7133/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
