----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7184/#review11727 -----------------------------------------------------------
third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/7184/#comment25304> This should really use path::join (here and elsewhere). third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/7184/#comment25302> Let's not kill the program here please. This will need to return a Try after all. third_party/libprocess/include/stout/os.hpp <https://reviews.apache.org/r/7184/#comment25303> Ditto. - Benjamin Hindman On Sept. 20, 2012, 1:45 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7184/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2012, 1:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Also fixes mktemp and mkdtemp > > > Diffs > ----- > > src/Makefile.am df86969 > src/common/type_utils.hpp f80cfce > src/examples/balloon_executor.cpp 3c84436 > src/slave/paths.hpp 0c817ca > src/tests/slave_state_tests.cpp d18e8a4 > third_party/libprocess/include/process/async.hpp d71b9ee > third_party/libprocess/include/stout/os.hpp 275e5ae > > Diff: https://reviews.apache.org/r/7184/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
