----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7214/#review11801 -----------------------------------------------------------
src/files/files.hpp <https://reviews.apache.org/r/7214/#comment25331> sounds like a switch is more appropriate here src/tests/files_tests.cpp <https://reviews.apache.org/r/7214/#comment25332> I think a test that confirms what you expect from a file and the return of JsonFileInfo(), would be nice. afaict, this is not testing the correctness of JsonFileInfo() - Vinod Kone On Sept. 21, 2012, 7:26 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7214/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 7:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This is for the webui file browsing, in order to mimic ls -l. > > > Diffs > ----- > > src/files/files.hpp 35037a613316846cc8bea259eaa9363705c0f1df > src/files/files.cpp c40b7b74485dc717c4291f17a4533b52f2c51a7e > src/tests/files_tests.cpp 17d284b82de4d9e1dedf1c26f4cedcf8269c4072 > third_party/libprocess/include/stout/format.hpp > eff0df4006375f62b78b7ca111981180ddf00529 > > Diff: https://reviews.apache.org/r/7214/diff/ > > > Testing > ------- > > Tests updated, make check on OSX. > > Running on CentOS currently. > > > Thanks, > > Ben Mahler > >
