> On Sept. 26, 2012, 9:38 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 326 > > <https://reviews.apache.org/r/7290/diff/1/?file=160209#file160209line326> > > > > Seconds(10) seems easier to read
Done. > On Sept. 26, 2012, 9:38 p.m., John Sirois wrote: > > src/detector/detector.cpp, line 446 > > <https://reviews.apache.org/r/7290/diff/1/?file=160209#file160209line446> > > > > Seconds(10) - can you lift this to 1 spot and re-use? Yes, done (with a comment to make this configurable). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7290/#review11950 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7290/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (2 of 7). > > > Diffs > ----- > > src/detector/detector.cpp 0246846 > > Diff: https://reviews.apache.org/r/7290/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
