> On Sept. 27, 2012, 9:31 p.m., Ben Mahler wrote: > > src/zookeeper/watcher.hpp, line 12 > > <https://reviews.apache.org/r/7294/diff/1/?file=160215#file160215line12> > > > > So why do we want to re-use watchers? Seems like it's adding > > complexity..?
It's more for safety (can't easily keep someone from reusing the watcher, so it's better to be conservative and assume it might happen). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7294/#review12001 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7294/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (6 of 7). > > > Diffs > ----- > > src/zookeeper/watcher.hpp b29bf7b > > Diff: https://reviews.apache.org/r/7294/diff/ > > > Testing > ------- > > make check (but test from https://reviews.apache.org/r/7293 is still failing). > > > Thanks, > > Benjamin Hindman > >
